[AppService] az functionapp: Only show warning but not throw error when checking runtime#28867
Merged
zhoxing-ms merged 1 commit intoAzure:devfrom May 13, 2024
Merged
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AppService |
zhoxing-ms
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp config appsettings setaz functionapp deployment source config-zipaz functionapp config setaz functionapp config container setDescription
Resolves #28394
Resolves #28382
Resolves #28358
Currently, we throw an error if we are unable to detect the runtime. However, there are many reasons why a linux app might not have a "conventional" runtime and runtime version (e.g. custom apps, centauri apps, apps running a docker image). For that reason, we should not be blocking command execution but should show a warning for how to set linuxFxVersion if we are unable to detect it and should not even show a warning when it is not applicable (e.g. centauri apps, apps running a docker image)
Testing Guide
History Notes
[AppService]
az functionapp: Not block execution of command when runtime cannot be detected, and omit showing warning for runtime when not applicable (e.g. centauri apps, apps running a docker image)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.