{Compute} Fix live test for vm image builder#28970
Merged
zhoxing-ms merged 3 commits intoAzure:devfrom May 29, 2024
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Compute |
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
zhoxing-ms
reviewed
May 15, 2024
| 'tmpl_01': 'template01', | ||
| 'tmpl_02': 'template02', | ||
| 'img_src': LINUX_IMAGE_SOURCE, | ||
| 'img_src': 'CANONICAL:UBUNTUSERVER:18_04-LTS-GEN2:latest', |
Contributor
There was a problem hiding this comment.
Why don't we consider changing LINUX_IMAGE_SOURCE directly to CANONICAL:UBUNTUSERVER:18_04-LTS-GEN2:latest?
Contributor
Author
There was a problem hiding this comment.
Some feature require gen2 image.
zhoxing-ms
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
fix live test
close #28909
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.