[Misc] homebrew: Generate shell completions for bash, fish, and zsh #30032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunet
requested review from
bebound,
calvinhzy,
jiasli,
kairu-ms and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
6 tasks
microsoft-github-policy-service
bot
added
the
customer-reported
maxbrunet
changed the title
maxbrunet
force-pushed
the
build/homebrew/shell-completion
branch
from
42ba9d7 to
bd211a7
Compare
Contributor
|
|
|
Hello @bebound 👋. I'm a maintainer for Homebrew. I'm seeking some clarity on your comment. Are you going to be using a method like |
Contributor
|
Hi @p-linnane, formula generation logic is here: It downloads the upstream formula, replaces the resource section, and makes some additional modifications. @maxbrunet Your PR also bump Python to 3.12, which may break the |
|
I'm the one who made the change bumping to Python 3.12. This was based on the release notes for azure-cli 2.64.0 stating it was supported for packaging. EDIT: Here is a PR adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Misc
Description
This switches to generate the completion with
register-python-argcompletedirectly, similarly to other Python tools like pipx in Homebrew.The
az.completion.shscript is not the actual completion, but runseval:azure-cli/src/azure-cli/az.completion.sh
Line 11 in 3194af8
This also adds completion support for zsh and fish.
Initially raised at Homebrew/homebrew-core#192912, but it was pointed out that the source of truth is here.
Testing Guide
Follow https://github.com/Homebrew/homebrew-core/blob/9ce8743dc3ea3a130f80dc2c120e896c7eaf47a0/CONTRIBUTING.md#to-contribute-a-fix-to-the-foo-formula
History Notes
[Misc] homebrew: Generate shell completions for bash, fish, and zsh
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.