[ACR] az acr agentpool: Fix delete polling#30485
Merged
Conversation
nguyenm2151
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
nguyenm2151
changed the title
added 2 commits
December 11, 2024 12:03
Contributor
Author
|
@zhoxing-ms @yonzhan can I get a review for this |
Contributor
|
May I ask if this change would be perceptible to users? |
Contributor
Author
|
Currently they see an error message after running that command (hence the regression). This change makes the command returns with no error message. So yes users will be able to see it |
nguyenm2151
changed the title
nguyenm2151
changed the title
nguyenm2151
changed the title
Contributor
Author
|
@yanzhudd i have changed the PR title since this change is perceptible to users |
yanzhudd
changed the title
az acr agentpool: Fix delete polling
yanzhudd
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az acr agentpool delete
Description
Revert some changes from this PR #30195 since we found an regression. Found an issue with self.cmd not detecting a command failure in this case. #30478
Testing Guide
acr agentpool delete -n {agents_name} -r {registry_name} -y
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.