Conversation
️✔️AzureCLI-FullTest
|
|
Hi @evelyn-ys, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
evelyn-ys
changed the title
az cloud register/update: Use ARM new API version 2022-09-01 for endpoint discoveryaz cloud register/update: Use ARM new API version 2022-09-01 for endpoint discovery
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/cloud/custom.py:37
- [nitpick] The function name
_populate_from_metadata_endpointis misleading as it now returns a value instead of populating the cloud object. Consider renaming it to_get_metadata_endpointsor similar.
def _populate_from_metadata_endpoint(arm_endpoint, session=None):
src/azure-cli/azure/cli/command_modules/cloud/custom.py:37
- The refactored function
_populate_from_metadata_endpointshould have corresponding tests to ensure it behaves correctly after the changes.
def _populate_from_metadata_endpoint(arm_endpoint, session=None):
3 tasks
evelyn-ys
modified the milestones:
May 2025 (2025-05-06),
Build 2025 (2025-05-19)❗ Breaking change release ❗
jiasli
approved these changes
Apr 27, 2025
jiasli
reviewed
Apr 27, 2025
| METADATA_ENDPOINT_SUFFIX = '/metadata/endpoints?api-version=2015-01-01' | ||
| if not arm_endpoint or all([cloud.endpoints.has_endpoint_set(n) for n in endpoints_in_metadata]): # pylint: disable=use-a-generator | ||
| return | ||
| def _populate_from_metadata_endpoint(arm_endpoint, session=None): |
Member
There was a problem hiding this comment.
Is it really necessary to change the function signature by removing cloud?
Member
Author
There was a problem hiding this comment.
Because now we generate a Cloud from none. While calling this func, there's no cloud yet so I have nothing to pass in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az cloud register/updateDescription
Close #25815, #28716
Upgrade ARM endpoint API from
/metadata/endpoints?api-version=2015-01-01to/metadata/endpoints?api-version=2022-09-01for cloud registration.Now data plane endpoints auto discovery is supported
But this will cause some output changes:
galleryendpointactiveDirectoryendpoint changed fromhttps://login.microsoftonline.com/tohttps://login.microsoftonline.commanagementendpoint explicitly set tohttps://management.core.windows.net/Testing Guide
Register cloud
az cloud register -n myCloud --endpoint-resource-manager https://management.azure.com/Check cloud
az cloud showBefore
After
History Notes
[Cloud] BREAKING CHANGE:
az cloud register/update: Nogalleryendpoint returned if use endpoint discovery with--endpoint-resource-manager[Cloud]
az cloud register/update: Support data plane endpoints auto discovery with--endpoint-resource-managerThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.