[AKS] az aks create/az aks nodepool add: Emit error message when using --asg-ids alone without --allowed-host-ports#30768
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
clnv
changed the title
--asg-ids alone without `--allowed-ho…--asg-ids alone without --allowed-host-ports
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
clnv
changed the title
--asg-ids alone without --allowed-host-ports--asg-ids alone without --allowed-host-ports
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
clnv
force-pushed
the
fix/nsg-control-validator
branch
from
8340039 to
9a27027
Compare
FumingZhang
reviewed
Feb 6, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
The change looks good to me, 2 comments
- Could you update the PR title (starting with
[AKS]) or write a separate history note in the PR description? This is a user-visible change, so it would be nice to have a corresponding note. - Could you also apply the change to cli-extensions/aks-preview?
clnv
changed the title
--asg-ids alone without --allowed-host-ports--asg-ids alone without --allowed-host-ports
Contributor
Author
|
Thanks for the review. Updated the title and will update the extension. @FumingZhang |
clnv
changed the title
--asg-ids alone without --allowed-host-portsaz aks create | az aks nodepool add Emit error message when using --asg-ids alone without --allowed-host-ports
clnv
changed the title
az aks create | az aks nodepool add Emit error message when using --asg-ids alone without --allowed-host-portsaz aks create | az aks nodepool add: Emit error message when using --asg-ids alone without --allowed-host-ports
yanzhudd
changed the title
az aks create | az aks nodepool add: Emit error message when using --asg-ids alone without --allowed-host-portsaz aks create/az aks nodepool add: Emit error message when using --asg-ids alone without --allowed-host-ports
yanzhudd
approved these changes
Feb 6, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks createaz aks nodepool addDescription
Before this change, users could use
--asg-idsalone without specifying--allowed-host-ports, which did nothing at all. This PR will now show an error message if that happens.Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.