[AKS] az aks update: Make specified version to match current version when turning off autoupgrade#31018
Merged
[AKS] az aks update: Make specified version to match current version when turning off autoupgrade#31018
az aks update: Make specified version to match current version when turning off autoupgrade#31018Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
reviewed
Mar 13, 2025
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31018 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yewmsft
changed the title
az aks update: Make specified version to match current version when turning off autoupgrade
FumingZhang
reviewed
Mar 30, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please fix failed PR title check. The failure in style check is not related to the change in this PR.
[AKS] az aks update: Make specified version to match current version when turning off autoupgrade: missing ` around az aks update
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_custom.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
yewmsft
force-pushed
the
dev
branch
2 times, most recently
from
2edc8fc to
632aad7
Compare
Member
Author
Fixed |
FumingZhang
reviewed
Mar 31, 2025
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yewmsft
force-pushed
the
dev
branch
4 times, most recently
from
dac1f8d to
b751fcc
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Mar 31, 2025
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
paulgmiller
approved these changes
Mar 31, 2025
yanzhudd
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
az aks update: Make specified version to match current version when turning off autoupgradeRelated command
az aks update -n <clusterName> -g <resourceGroup> --auto-upgrade-channel noneDescription
This change is for accommodating an AKS RP validation rule change. When turning off autoupgrade on a aks cluster, AKS RP requires the cluster's specified kubernetes version to be greater or equal to the current kubernetes version. To unblock the cli usage to turning off autoupgrade, we are making specified k8s version to match current k8s version during the update.
Testing Guide
pytest -k test_update_kubernetes_version_and_orchestrator_version
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.