Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
customer-reported
Contributor
|
Thank you for your contribution tsatam! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
Auto-Assign
yonzhan
modified the milestones:
April 2025 (2025-04-01),
Build 2025 (2025-05-19)❗ Breaking change release ❗,
May 2025 (2025-05-06)
kairu-ms
approved these changes
Mar 27, 2025
tsatam
deleted the
aro-ensure-resource-permissions-tolerate-missing-subnets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aro updateDescription
The current implementation of the
ensure_resource_permissionsfunction, called duringaz aro createandaz aro update --refresh-credentials, and which is responsible for ensuring an ARO cluster's service principal has the required permissions over the cluster's network resources (vnet, subnet, route tables, NAT Gateways, NSGs), has a bug where if a cluster was either created with a specific subnet provided for the worker nodes that has since been deleted, or the cluster currently has an invalid machineset pointing to a nonexistent subnet (e.g. following the instructions in https://learn.microsoft.com/en-us/azure/openshift/howto-segregate-machinesets incorrectly), we will fail to ensure the required resource permissions over this nonexistent subnet. We retrieve each subnet to obtain the resource IDs of any attached route tables, NAT gateways, and NSGs, in order to ensure we have the required role assignment scoped to that resource.This PR changes the above approach to skip any such subnets, allowing this process to complete successfully. We expect all passed-in subnets to exist at cluster creation time, so this change should only impact
az aro update(other validation during the creation process ensures that all passed-in subnets exist).Testing Guide
In order to reproduce this scenario, one would need to create an ARO cluster, and then create a machineset pointing to an invalid subnet, by following https://learn.microsoft.com/en-us/azure/openshift/howto-segregate-machinesets. The
az aro updatecommand should work successfully with this change applied.History Notes
[ARO]
az aro update: Ensure that refreshing cluster service principal credentials is successful when the cluster has an invalid or missing subnet in its resource definitionThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.