Conversation
anujmaheshwari1
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @anujmaheshwari1, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
| - name: --os-sku | ||
| type: string | ||
| short-summary: The OS SKU of the agent node pool. Ubuntu or CBLMariner for Linux. Windows2019 or Windows2022 for Windows. | ||
| short-summary: The OS SKU of the agent node pool. Ubuntu, CBLMariner or Ubuntu2204 for Linux. Windows2019 or Windows2022 for Windows. |
There was a problem hiding this comment.
Is CBLMariner actually allowed here?
Maybe fix the docs?
There was a problem hiding this comment.
CBLMariner is no longer allowed: https://msazure.visualstudio.com/CloudNativeCompute/_git/aks-rp?path=/resourceprovider/server/microsoft.com/containerservice/server/validation/validators/ossku/linux_validator.go&version=GBmaster&_a=contents
Henry, one of the leads for Mariner has confirmed that we should drop CBLMariner and replace it with AzureLinux in the docs instead.
There was a problem hiding this comment.
updated the PR.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
Queued live test to validate the change.
successful live test: https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=118998281&view=results had to set location to eastus2euap |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 31119 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@anujmaheshwari1 please fix the failure in style check |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
Ubuntu2204 to --os-sku for az aks nodepool add and az aks nodepool updateaz aks nodepool add/update: Add option Ubuntu2204 to --os-sku parameter
|
May I ask if there is any breaking change in this PR, like some available values being removed? |
I would say this is not a breaking change. On the one hand, the change only changed the help information of the option and did not prevent users from using the value 
|
7 participants
[AKS] Add option
Ubuntu2204to--os-skuforaz aks nodepool addandaz aks nodepool updateAzure CLI extension PR: Azure/azure-cli-extensions#8597
Related command
az aks nodepool add
az aks nodepool update
Description
Customers can use this parameter to select Ubuntu2204 as OSSKU when creating Linux nodepools.
Testing Guide
azdev test --live test_aks_nodepool_add_with_ossku_ubuntu2204
History Notes
N/A
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.