Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| ad sp create-for-rbac | cmd ad sp create-for-rbac added parameter service_management_reference |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
az ad sp create-for-rbac enhancement |
microsoft-github-policy-service
bot
requested review from
calvinhzy,
evelyn-ys and
yonzhan
jiasli
force-pushed
the
service_management_reference
branch
from
91bc9c6 to
cc44c55
Compare
jiasli
force-pushed
the
service_management_reference
branch
from
cc44c55 to
c13329a
Compare
evelyn-ys
reviewed
Apr 9, 2025
| def test_create_for_rbac_service_management_reference(self): | ||
| self.kwargs.update({ | ||
| 'display_name': self.create_random_name('azure-cli-test-', 30), | ||
| 'service_management_reference': '96524024-75b0-497b-ab38-0381399a6a9d' |
Member
There was a problem hiding this comment.
Just curious, if it's a dummy GUID, how did you make the test pass?
Member
Author
There was a problem hiding this comment.
I am using our testing tenant to run the live test. The testing tenant has no restriction on the GUID. Only in Microsoft tenant, a real Service Tree ID is needed. (Of course, I used our true service tree ID.)
bebound
approved these changes
Apr 9, 2025
evelyn-ys
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az ad sp create-for-rbacDescription
Close #30717
Without
--service-management-reference,az ad sp create-for-rbacfails in Microsoft tenant:Same as #29860, this PR adds
--service-management-referenceargument toaz ad sp create-for-rbacin order to set theserviceManagementReferenceproperty on the created application.Testing Guide
Note:
96524024-75b0-497b-ab38-0381399a6a9dis only a dummy GUID. In Microsoft tenant, a real Service Tree ID must be provided; Otherwise, this command fails with