Skip to content

{RDBMS} az postgres flexible-server create: Remove the breaking change from validators and breaking_change file #31399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 3 commits into from
May 8, 2025
Merged

{RDBMS} az postgres flexible-server create: Remove the breaking change from validators and breaking_change file #31399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8927e92
{RDBMS} az postgres flexible-server create: Remove the breaking chang…
May 2, 2025
fee4c00
remove unused param
May 2, 2025
40d25c7
Merge branch 'dev' of https://github.com/mattboentoro/azure-cli into …
May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/azure-cli/azure/cli/command_modules/rdbms/_breaking_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,12 @@
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

from azure.cli.core.breaking_change import register_default_value_breaking_change, \
register_other_breaking_change, register_logic_breaking_change
from azure.cli.core.breaking_change import register_other_breaking_change, register_logic_breaking_change


register_logic_breaking_change('postgres flexible-server create', 'Update default value of "--sku-name"',
detail='The default value will be changed from "Standard_D2s_v3" to a '
'supported sku based on regional capabilities.')
register_default_value_breaking_change('postgres flexible-server create', '--version', '16', '17')
register_default_value_breaking_change('postgres flexible-server create', '--create-default-database', 'Enabled',
'Disabled')
register_other_breaking_change('postgres flexible-server update',
message='User confirmation will be needed for compute and storage updates '
'that trigger a restart of the server.')
9 changes: 2 additions & 7 deletions src/azure-cli/azure/cli/command_modules/rdbms/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def pg_arguments_validator(db_context, location, tier, sku_name, storage_gb, ser
_pg_storage_validator(storage_gb, sku_info, tier, storage_type, iops, throughput, instance)
_pg_sku_name_validator(sku_name, sku_info, tier, instance)
_pg_high_availability_validator(high_availability, standby_availability_zone, zone, tier, single_az, instance)
_pg_version_validator(version, list_location_capability_info['server_versions'], is_create)
_pg_version_validator(version, list_location_capability_info['server_versions'])
pg_byok_validator(byok_identity, byok_key, backup_byok_identity, backup_byok_key, geo_redundant_backup, instance)
is_microsoft_entra_auth = bool(microsoft_entra_auth is not None and microsoft_entra_auth.lower() == 'enabled')
_pg_authentication_validator(password_auth, is_microsoft_entra_auth,
Expand Down Expand Up @@ -510,7 +510,7 @@ def _pg_storage_performance_tier_validator(performance_tier, sku_info, tier=None
' Allowed values : {}'.format(storage_size, performance_tiers))


def _pg_version_validator(version, versions, is_create):
def _pg_version_validator(version, versions):
if version:
if version not in versions:
raise CLIError('Incorrect value for --version. Allowed values : {}'.format(sorted(versions)))
Expand All @@ -519,11 +519,6 @@ def _pg_version_validator(version, versions, is_create):
"We recommend selecting PostgreSQL 13 or a later version for "
"all future operations.")

if is_create:
# Warning for upcoming breaking change to default value of pg version
logger.warning("The default value for the PostgreSQL server major version "
"will be updating to 17 in the near future.")


def _pg_high_availability_validator(high_availability, standby_availability_zone, zone, tier, single_az, instance):
if instance:
Expand Down