{App Service} az functionapp create: Fix the functionapp unit tests#31416
{App Service} az functionapp create: Fix the functionapp unit tests#31416zhoxing-ms merged 1 commit intoAzure:devfrom
az functionapp create: Fix the functionapp unit tests#31416Conversation
|
Hi @khkh-ms, |
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
zhoxing-ms
changed the title
az functionapp create: Fix the functionapp unit testsaz functionapp create: Fix the functionapp unit tests
|
I don't think delaying the EOL date with The correct way is to mock the current time and verify the before and after behavior. All tests should be time-irrelevant. As azure-cli/src/azure-cli-core/azure/cli/core/auth/util.py Lines 201 to 203 in 5c3cf2f which can be mocked during tests: But I recommend creating your own |
…Azure#31416) # Conflicts: # src/azure-cli/azure/cli/command_modules/appservice/tests/latest/recordings/test_functionapp_on_linux_version.yaml # src/azure-cli/azure/cli/command_modules/appservice/tests/latest/recordings/test_functionapp_windows_runtime_version.yaml
4 participants
Related command
Only integration tests are fixed.
Description
Fixing the function app unit tests.
Testing Guide
azdev test test_functionapp_on_linux_version --lf --no-exitfirst --live --discoverazdev test test_functionapp_windows_runtime_version --lf --no-exitfirst --liveHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.