[Compute] az vmss create: Add new parameter --enable-automatic-repairs to support setting automatic repairs policy#31722
Merged
zhoxing-ms merged 5 commits intoAzure:devfrom Jul 22, 2025
Conversation
Jing-song
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vmss create | cmd vmss create added parameter enable_automatic_repairs |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new parameter --enable-automatic-repairs to the vmss create command so that users can configure the automatic repairs policy and improves related validations and template generation. Key changes include new test cases for the parameter, updates to function signatures and error validations, and modifications to template building logic to support the repairs policy.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/latest/test_vm_commands.py | Added new test case for vmss with automatic repairs and zone balancing |
| custom.py | Updated create_vmss function signature to include enable_automatic_repairs |
| _validators.py | Added validation logic to raise an error for incompatible repairs settings |
| _template_builder.py | Updated build_vmss_resource signature and logic to support enable_automatic_repairs |
| _params.py | Introduced a new command argument for enable_automatic_repairs |
| _utils.py | Improved HTTP response error handling with additional exception support |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/vm/_template_builder.py:1047
- [nitpick] Consider updating the function docstring for build_vmss_resource to document the new parameter 'enable_automatic_repairs'.
automatic_zone_balancing_strategy=None, automatic_zone_balancing_behavior=None,
microsoft-github-policy-service
bot
added
the
Compute
zhoxing-ms
reviewed
Jun 26, 2025
Comment on lines
+90
to
+95
| from azure.core.exceptions import StreamClosedError, StreamConsumedError | ||
| try: | ||
| error_txt = http_error.response.internal_response.text | ||
| error_info = json.loads(error_txt)['error'] | ||
| except (StreamClosedError, StreamConsumedError): | ||
| error_info = http_error.response.json()['error'] |
Contributor
There was a problem hiding this comment.
Could you recording some az deployment related tests to check the fix effect of ARM deployment
zhoxing-ms
previously approved these changes
Jun 26, 2025
zhoxing-ms
changed the title
az vmss create Add new parameter --enable-automatic-repairs to support setting automatic repairs policyaz vmss create: Add new parameter --enable-automatic-repairs to support setting automatic repairs policy
zhoxing-ms
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
close #31585
Fix #31709 #31581
Testing Guide
History Notes
[Compute]
az vmss create: Add new parameter--enable-automatic-repairsto support setting automatic repairs policy[ARM] Fix #31709:
az deployment: Fixthe content for this response was already consumedwhen create resourceThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.