Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
bebound
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure CLI to support Python 3.13 by adding it as a supported programming language classifier in setup files and updating CI configurations to use Python 3.13 as the default version.
- Add Python 3.13 support declarations to all setup.py files
- Update CI pipeline configurations to use Python 3.13 as the default version
- Update documentation to reflect Python 3.9-3.13 support range
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/setup.py | Add Python 3.13 classifier |
| src/azure-cli-testsdk/setup.py | Add Python 3.13 classifier |
| src/azure-cli-telemetry/setup.py | Add Python 3.13 classifier |
| src/azure-cli-core/setup.py | Add Python 3.13 classifier |
| scripts/regression_test/regression_test.yml | Update Python version from 3.12 to 3.13 |
| scripts/ci/test_extensions.sh | Add serviceconnector-passwordless to ignore list and remove extension name from error message |
| doc/install_linux_prerequisites.md | Update supported Python versions and remove Ubuntu 20.04 LTS |
| doc/extensions/authoring.md | Update supported Python versions |
| doc/command_guidelines.md | Update supported Python versions |
| azure-pipelines.yml | Update Python version from 3.12 to 3.13 in CI jobs |
| azure-pipelines-full-tests.yml | Update Python version from 3.9/3.12 to 3.12/3.13 |
| .azure-pipelines/breaking-change-tests.yml | Update Python version from 3.12 to 3.13 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| then | ||
| exit_code=1 | ||
| echo "Failed to verify:" $ext | ||
| echo "Failed to verify" |
There was a problem hiding this comment.
The error message has been made less informative by removing the extension name variable. This makes debugging more difficult as it no longer indicates which specific extension failed verification.
There was a problem hiding this comment.
$ext is meaningless, it always points to last extension.
There was a problem hiding this comment.
I guess this line is copy-and-pasted from L55 without too much thinking.
| Python39: | ||
| python.version: '3.9' |
There was a problem hiding this comment.
We should not drop Python 3.9's test as we need to make sure our code works on Python 3.9
There was a problem hiding this comment.
We only test the Python which is used in official package.
Currently, RPM used 3.12, DEB, macOS and Windows use 3.13.
|
No need to bump pylint and updating linter rules? We did a lot to support Python 3.12: #27673. |
There no major version bump in Pylint. Azdev is using the latest version.
|
# Conflicts: # azure-pipelines-full-tests.yml # doc/command_guidelines.md # doc/extensions/authoring.md # doc/install_linux_prerequisites.md # scripts/regression_test/regression_test.yml
Description
Changes:
setup.pyto support 3.13