Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
@evelyn-ys @yonzhan please trigger checks |
There was a problem hiding this comment.
Pull request overview
This PR enables SSDV2 (Premium SSD V2) PostgreSQL flexible servers to use geo-redundancy, geo-restore, and read replica features. The changes remove validation blocks that previously prevented SSDV2 servers from using these capabilities.
Changes:
- Removed geo-redundancy validation restriction for SSDV2 servers in the storage type validator
- Removed SSDV2 blocking checks from replica creation and geo-restore operations
- Updated test to use dynamic location and removed the negative test case for replica creation
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| validators.py | Removed validation that blocked geo-redundant backups for SSDV2 servers |
| flexible_server_custom_postgres.py | Removed SSDV2 checks that prevented replica creation and geo-restore operations |
| test_postgres_flexible_commands_ssdv2.py | Changed hardcoded location to dynamic location and removed replica creation error test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| backup_retention = 7 | ||
| server_name = self.create_random_name(SERVER_NAME_PREFIX, SERVER_NAME_MAX_LENGTH) | ||
| location = 'canadacentral' | ||
| location = self.postgres_location |
There was a problem hiding this comment.
The test file now enables replica creation and geo-restore for SSDV2 servers, but no positive test cases have been added to verify these newly supported features work correctly. Consider adding test cases for: (1) creating a replica from an SSDV2 server, (2) performing geo-restore on an SSDV2 server with geo-redundant backups enabled, and (3) creating an SSDV2 server with geo-redundant backups enabled.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4 participants
Related command
az postgres flexible-server createaz postgres flexible-server georestoreaz postgres flexible-server replica createDescription
Cli currently blocks creating HA / Geo redundant backups enabled servers. Please unblock them across all regions.
Geo redundancy
Geo restore
Read replica
MVU
Testing Guide
manual
History Notes
[POSTGRESQL]
az postgres flexible-server create/georestore/replica: Allow SSDV2 servers to perform create replica and geo restore