{POSTGRESSQL} Include .json files in package data#32661
{POSTGRESSQL} Include .json files in package data#32661DanielMicrosoft merged 1 commit intoAzure:devfrom
.json files in package data#32661Conversation
️✔️AzureCLI-FullTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @DanielMicrosoft, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
️✔️AzureCLI-BreakingChangeTest
|
There was a problem hiding this comment.
Pull request overview
This PR fixes Batched-CI build failures by ensuring that JSON configuration files in the PostgreSQL command module are included in the package distribution. The config.json file is required at runtime by the _config_reader.py module but was previously missing from the package data.
Changes:
- Added
*.jsonpattern to package_data for the postgresql module to include configuration files in the build
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
Description
This PR addresses failures in
Batched-CIthat appear to have started here: https://dev.azure.com/azclitools/public/_build/results?buildId=291171&view=results / #32598Failure looks to be due to
config.jsonnot being included in build. The tests may run locally as venv may use files from your local filesystem.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.