[ACR] Improve error message in running acr login in cloud shell#5347
Merged
yugangw-msft merged 1 commit intoAzure:devfrom Jan 19, 2018
Merged
[ACR] Improve error message in running acr login in cloud shell#5347yugangw-msft merged 1 commit intoAzure:devfrom
yugangw-msft merged 1 commit intoAzure:devfrom
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5347 |
Member
Author
|
@yugangw-msft I will rebase once your PR is merged. |
Contributor
|
Thanks for the quick PR @djyou - the error message looks sufficient to me. Hopefully this mention of error enables users to realize they should use docker-machine or some other machine that can run docker sufficiently. |
yugangw-msft
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5341
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)