[Network] AppGateway: Support for zones, autoscale config and trusted root certs#7789
Merged
tjprescott merged 4 commits intoAzure:devfrom Nov 13, 2018
tjprescott:NetworkFix
Merged
[Network] AppGateway: Support for zones, autoscale config and trusted root certs#7789tjprescott merged 4 commits intoAzure:devfrom tjprescott:NetworkFix
tjprescott merged 4 commits intoAzure:devfrom
tjprescott:NetworkFix
Conversation
6 tasks
Member
Author
|
@yugangw-msft ping |
yugangw-msft
approved these changes
Nov 9, 2018
Contributor
yugangw-msft
left a comment
yugangw-msft
left a comment
There was a problem hiding this comment.
If it is cheap(I mean not running for 5+ minutes), I would suggest add test coverage for cert
src/command_modules/azure-cli-network/azure/cli/command_modules/network/_help.py
Outdated
Show resolved
Hide resolved
src/command_modules/azure-cli-network/azure/cli/command_modules/network/_validators.py
Outdated
Show resolved
Hide resolved
tjprescott
changed the title
yugangw-msft
approved these changes
Nov 10, 2018
Member
Author
|
Plan to add the remaining asks to this PR. |
Member
Author
|
@yugangw-msft added some more of the feature asks. Will push off the WAF exclusions since it is poorly documented. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7528. WAF exclusions are being, well, excluded because there is no service-side documentation to how to they work.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.