Fix 7973 - Call SubResource correctly in list comprehension#7974
Merged
tjprescott merged 1 commit intoAzure:devfrom Dec 4, 2018
justenwalker:gh-7973
Merged
Fix 7973 - Call SubResource correctly in list comprehension#7974tjprescott merged 1 commit intoAzure:devfrom justenwalker:gh-7973
tjprescott merged 1 commit intoAzure:devfrom
justenwalker:gh-7973
Conversation
Call SubResource(id=x) instead of SubResource(x) in list comprehension since the latter introduced a type error and prevented az network lb outbound-rule update from being used with the --frontend-ip-configs flag This fixes GH-7973
tjprescott
approved these changes
Dec 4, 2018
Member
|
@justenwalker thanks for the contribution! |
williexu
pushed a commit
to williexu/azure-cli
that referenced
this pull request
Dec 4, 2018
Call SubResource(id=x) instead of SubResource(x) in list comprehension since the latter introduced a type error and prevented az network lb outbound-rule update from being used with the --frontend-ip-configs flag This fixes AzureGH-7973
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
SubResource(id=x)instead ofSubResource(x)in list comprehension, since the latter introduced aTypeErrorand preventedaz network lb outbound-rule updatefrom being used with the--frontend-ip-configsflagThis fixes GH-7973