[Monitor] Support additional special characters in metrics alert create.#8242
Merged
tjprescott merged 1 commit intoAzure:devfrom Jan 14, 2019
tjprescott:MonitorGrammarFixes
Merged
[Monitor] Support additional special characters in metrics alert create.#8242tjprescott merged 1 commit intoAzure:devfrom tjprescott:MonitorGrammarFixes
metrics alert create.#8242tjprescott merged 1 commit intoAzure:devfrom
tjprescott:MonitorGrammarFixes
Conversation
adewaleo
approved these changes
Jan 14, 2019
Contributor
adewaleo
left a comment
adewaleo
left a comment
There was a problem hiding this comment.
Looks fine to me, seeing almost all of this was generated python code and it passes CI.
| @@ -0,0 +1 @@ | |||
| java org.antlr.v4.Tool %* No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I do have a question though, would it be desired to make the scripts platform-independent?
Member
Author
There was a problem hiding this comment.
Philosophically, yes. Practically, no. Regardless of your dev environment, if you need to modify the grammar, you have to do a bunch more manual setup to be able to generate the grammar code anyways.
Contributor
There was a problem hiding this comment.
Is this manual setup documented somewhere, or at least a pointer to somewhere with instructions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7598.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.