Skip to content

Temp fix for no match for request bug. Fixes #9591 #9593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adewaleo wants to merge 3 commits into from
Closed

Temp fix for no match for request bug. Fixes #9591 #9593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9eb04b
Temp fix for no match for request bug. Fixes #9591
Jun 7, 2019
19f5b22
Ensure that rg monikers are unique enough for live tests.
Jun 7, 2019
dcd03dd
Undo change to make monikers unique for live tests as this would reuq…
Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/azure-cli-testsdk/azure/cli/testsdk/preparers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ def live_only_execute(self, cli_ctx, command, expect_failure=False):

return None

@property
def random_name(self):
# override random_name so that in play-back mode the name is deterministic.
# non-deterministic preparers have no recording of requests involved in creating the resource
return self.moniker
Copy link
Member

@tjprescott tjprescott Jun 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only supposed to apply to playback mode, then should it not be something like:

if self.is_live:
  return random_thing
else:
  return self.moniker

?



# Resource Group Preparer and its shorthand decorator

Expand Down
Loading