Fixed default order of the identities#1286
Merged
v-anvashist merged 1 commit intoSep 15, 2022
Merged
Conversation
* Changed comparison to support actual data typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_token_from_az_logins() method uses the wrong comparison when finding an active subscription from az login data. The code fails to insert active subscription as first identity without outputting any errors or warning.
This PR fixes comparison and active subscription is added into tenantsDict as first item.
Compare with get_default_subscription_info() in same file.
Please make sure the code is following contribution guidelines in CONTRIBUTING.md