ELM migrations: status compatibility, create-flow enhancements, and device auth UX by bhuvanshahMSFT · Pull Request #1494 · Azure/azure-devops-cli-extension

bhuvanshahMSFT · 2026-04-28T16:42:28Z

Summary

This PR now includes the combined ELM migrations updates for preview labeling, status compatibility, create-flow enhancements, and device auth UX.

What Changed

Status compatibility:

Treat both succeeded and completed as success terminal states.

Create migration enhancements:

Added optional --service-endpoint-id passthrough as serviceEndpointId (camelCase).
Kept --github-token support.
If token is not provided, CLI checks ELM_GITHUB_TOKEN, then falls back to GitHub device flow.

Device flow UX:

Shows verification URL and device code.
Copies device code to clipboard when host OS supports it.

UX improvements across migration commands:

Improved pause/cancel/abandon/list messaging.
Improved resume guidance and terminal-state handling.

Preview label:

Keeps ELM migration command group marked as Preview.

Validation

Migration unit tests passed: 65/65.
Wheel rebuilt and installed: azure_devops-1.0.4-py2.py3-none-any.whl.
CLI smoke checks passed for command help and merged arguments (--service-endpoint-id, --github-token).

Notes

serviceEndpointId is sent only when provided.
API contract confirmed camelCase and nullable GUID behavior.

- Add --github-token and ELM_GITHUB_TOKEN fallback - Run GitHub device flow when token is not provided - Keep target-owner-user-id optional for FF-off compatibility - Add deviceFlowConfig endpoint fallback support - Expand migration auth edge-case tests - Update ELM docs for token/device-flow create behavior

- Translate generic 409 TF400898 during migration create into a clear active-migration message - Keep non-conflict errors unchanged - Add regression tests for conflict mapping and pass-through behavior

- Add troubleshooting entry in migrations.md - Add pitfall row and dedicated 409 section in elm_migrations_tsg.md

- Show PAT guidance when both device-flow config endpoints return 404 - Validate interval/expires_in as positive integers and fail with explicit invalid response errors - Add regression tests for new fallback and validation behavior

- Map 401/403 to generic app/service-unavailable message - Preserve PAT fallback guidance in message - Add unit test coverage for HTTP 401 handling

- Enforce target repository format as https://host/org/repo client-side - Prefer PreCheckIssueType/validation issue messages from response body for CLI errors - Keep non-TF400898 409 handling unchanged - Add regression tests for new validation and error-detail extraction

Add is_preview for migrations command groups and align help/docs with preview and limited-availability messaging.

bhuvanshahMSFT · 2026-04-28T16:43:34Z

Reviewer context: this change is metadata and docs only. It marks ELM migration command groups as Preview to reflect current limited 1P or allowlisted availability. Existing CLI usage is unchanged for eligible users; non-eligible users continue to be governed by service-side access controls.

…nal status handling

…resume error messages

…se Server migrations

bhuvanshahMSFT · 2026-04-29T23:20:29Z

Update after branch refresh:

This PR branch now includes the merged ELM migration functional updates (not just preview metadata):

Status compatibility:

Treats both succeeded and completed as success terminal states.

Create migration enhancements:

Adds optional --service-endpoint-id passthrough as serviceEndpointId (camelCase).
Keeps --github-token support.
If token is not provided, CLI checks ELM_GITHUB_TOKEN, then falls back to GitHub device flow.

Device flow UX:

Displays device verification URL and code.
Copies device code to clipboard when supported by host OS tooling.

UX improvements across migration commands:

Better pause/cancel/abandon/list messaging.
Improved resume guidance and terminal-state handling.

Validation done on this branch:

Migration unit tests passed: 65/65.
Wheel rebuilt and installed: azure_devops-1.0.4-py2.py3-none-any.whl.
CLI help smoke checks confirm merged args/commands (including --service-endpoint-id and --github-token).

If preferred, I can update PR title/description to match this expanded scope for easier review.

…ation

This reverts commit ed0bb92.

This reverts commit 16f0c06.

…own lint

bhaveshbhati

Need to delete extra/wrong files

bhaveshbhati · 2026-05-13T06:50:39Z

Delete this file.

bhaveshbhati · 2026-05-13T06:50:52Z

Delete this file

When a service connection is supplied via --service-endpoint-id, GitHub auth is handled server-side by the service endpoint. The CLI must not call /_apis/migrations/deviceFlowConfig, which fails (400) against GHES when the ELM GitHub App is not reachable from the caller's network. - Gate _resolve_github_user_token on service_endpoint_id - Reject --service-endpoint-id and --github-token together (ambiguous) - Update help text to document precedence - Add tests covering: SE-only, SE+token mutex, SE ignores env token, SE+whitespace token, SE+409 conflict message, SE+all optional fields

…led cutover date The ELM service silently ignores 'null' for scheduledCutoverDate and only treats DateTimeOffset.MinValue ('0001-01-01T00:00:00+00:00') as the clear sentinel. Previously, 'az devops migrations cutover cancel' returned 200 OK but the server left the field set, leading users to believe the cancel had taken effect when it had not. Verified empirically via 'az devops invoke' against a live stuck migration: sending the MinValue sentinel cleared scheduledCutoverDate to null in the response, while sending null was a silent no-op. Updated unit test to assert the sentinel value is sent.

Replace specific pool names and aliases with generic placeholders in customer-facing help text, docs, and test fixtures.

Clearing scheduledCutoverDate after the worker has entered the Cutover stage puts the migration into a state that requires server-side recovery (the post-cutover drain uses the field as a 'final sync ran' marker). Tracked service-side as Bug 2394803. Guard the dangerous case client-side until the service-side reject ships, so customers running 'az devops migrations cutover cancel' against an in-progress cutover get a clear error instead of corrupting the migration state.

bhaveshbhati

LGTM

bhuvanshah7 added 7 commits April 22, 2026 15:00

Improve ELM create conflict error messaging

1b753e6

- Translate generic 409 TF400898 during migration create into a clear active-migration message - Keep non-conflict errors unchanged - Add regression tests for conflict mapping and pass-through behavior

Document 409 conflict error behavior for migration create

c738a74

- Add troubleshooting entry in migrations.md - Add pitfall row and dedicated 409 section in elm_migrations_tsg.md

Handle device-flow 401/403 with generic guidance

78d26f6

- Map 401/403 to generic app/service-unavailable message - Preserve PAT fallback guidance in message - Add unit test coverage for HTTP 401 handling

Mark ELM migrations command group as preview

e1fc264

Add is_preview for migrations command groups and align help/docs with preview and limited-availability messaging.

bhuvanshahMSFT requested review from mishrarish, v-anvashist and v-soujanya as code owners April 28, 2026 16:42

bhuvanshah7 added 7 commits April 28, 2026 16:39

ELM migrations: treat 'completed' equivalent to 'succeeded' for termi…

846015f

…nal status handling

ELM migrations abandon: return success message instead of empty object

b2a6ca7

ELM migrations: UX improvements for pause, cancel, list, abandon and …

77d7967

…resume error messages

ELM migrations: add service-endpoint-id parameter for GitHub Enterpri…

d9ad217

…se Server migrations

Add tests for service-endpoint-id parameter

e24da3f

ELM device flow: copy user code to clipboard when available

3e39607

Merge device-flow auth into elm-migrations preview branch

0b3eb43

bhuvanshahMSFT changed the title ~~Mark ELM migrations command group as preview~~ ELM migrations: status compatibility, create-flow enhancements, and device auth UX Apr 29, 2026

bhuvanshah7 and others added 10 commits April 30, 2026 11:12

Fix: skip github token resolution when service-endpoint-id is provided

2b3cd04

ELM abandon: add optional remove-read-only flag

14067aa

ELM cutover: add review and approve CLI flow

e629790

fix: always resolve github user token regardless of service endpoint

7c403f6

Initial commit: Add README and hello.js

7b96f92

Fix ELM style checks

4eaab8c

Add migration workflow guide for operators and repo owners

ed0bb92

Fix R0917: use keyword-only args in create_migration and _update_migr…

fef8a84

…ation

Revert "Add migration workflow guide for operators and repo owners"

0c7cd7b

This reverts commit ed0bb92.

Remove ELM_Demo_Script.md

16f0c06

Demo User added 2 commits May 11, 2026 09:08

Revert "Remove ELM_Demo_Script.md"

3de1822

This reverts commit 16f0c06.

Remove ELM_Demo_Script.md

0e84488

bhuvanshahMSFT force-pushed the elm-migrations-preview-1p branch from 0e63a5a to 0e84488 Compare May 11, 2026 16:49

Restore upstream README and remove stray E2E_TEST_REPORT to fix markd…

ba8b15c

…own lint

bhaveshbhati reviewed May 13, 2026

View reviewed changes

Comment thread docs Outdated

Copy link
Copy Markdown

Collaborator

bhaveshbhati May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file.

bhaveshbhati reviewed May 13, 2026

View reviewed changes

Comment thread hello.js Outdated

Copy link
Copy Markdown

Collaborator

bhaveshbhati May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file

Demo User added 5 commits May 13, 2026 09:39

Remove stray hello.js and docs gitlink accidentally added

d4a4857

chore(migration): sanitize internal identifiers from ELM help/docs/tests

35ad24b

Replace specific pool names and aliases with generic placeholders in customer-facing help text, docs, and test fixtures.

bhaveshbhati approved these changes May 14, 2026

View reviewed changes

mishrarish approved these changes May 14, 2026

View reviewed changes

mishrarish merged commit 08344c5 into Azure:master May 14, 2026
21 checks passed

mishrarish mentioned this pull request May 15, 2026

Release 1.0.4 Azure/azure-cli-extensions#9876

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ELM migrations: status compatibility, create-flow enhancements, and device auth UX#1494

ELM migrations: status compatibility, create-flow enhancements, and device auth UX#1494
mishrarish merged 32 commits into
Azure:masterfrom
bhuvanshahMSFT:elm-migrations-preview-1p

bhuvanshahMSFT commented Apr 28, 2026 •

edited

Loading

Uh oh!

bhuvanshahMSFT commented Apr 28, 2026

Uh oh!

bhuvanshahMSFT commented Apr 29, 2026

Uh oh!

bhaveshbhati left a comment

Uh oh!

bhaveshbhati May 13, 2026

Uh oh!

bhaveshbhati May 13, 2026

Uh oh!

bhaveshbhati left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bhuvanshahMSFT commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Validation

Notes

Uh oh!

bhuvanshahMSFT commented Apr 28, 2026

Uh oh!

bhuvanshahMSFT commented Apr 29, 2026

Uh oh!

bhaveshbhati left a comment

Choose a reason for hiding this comment

Uh oh!

bhaveshbhati May 13, 2026

Choose a reason for hiding this comment

Uh oh!

bhaveshbhati May 13, 2026

Choose a reason for hiding this comment

Uh oh!

bhaveshbhati left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bhuvanshahMSFT commented Apr 28, 2026 •

edited

Loading