fix: allow union typing for supported bindings#239
Draft
hallvictoria wants to merge 5 commits intodevfrom
Draft
Conversation
hallvictoria
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo: support built-in collection types (list) after Bill's PR is merged
Python 3.10 and above allow for
ABCMeta | _GenericAliastype hinting syntax.(For example:
event: func.EventHubEvent | List[func.EventHubEvent])For bindings that allow
List[<type>]type hints, this allows for the new syntax.This is accomplished by:
- Adding a new method as part of the type checking process
- The new method will parse the individual types in the
Unionand determine if all of the types are supported- If any of the types in the
Unionaren't supported, indexing will fail- As this new method is part of an
orstatement in type checking, it won't affect any currently supported type hintsBindings that can now support this syntax:
- EventHub
- Kafka
- ServiceBus
Fixes: Azure/azure-functions-python-worker#1524