Ensure ASGI State is added to all subsequent ASGI requests#240
Closed
ashleysommer wants to merge 3 commits intoAzure:devfrom
Closed
Ensure ASGI State is added to all subsequent ASGI requests#240ashleysommer wants to merge 3 commits intoAzure:devfrom
ashleysommer wants to merge 3 commits intoAzure:devfrom
Conversation
ashleysommer
requested review from
YunchuWang,
gavin-aguiar,
hallvictoria,
pdthummar and
vrdmr
as code owners
Author
|
Still waiting on a human review... |
Contributor
|
Hey @ashleysommer, thanks for this. I ported your changes over to #310 to add some tests. Please feel free to take a look and let me know if you have any questions |
Contributor
|
Closing in favor of the other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ASGIMiddlewareclass has astate(Dict) property.State can be written to if the ASGI Lifespan startup handler writes to it, but it is never used for anything after that.
The ASGI Spec states that contents of the lifespan startup's state dict is stored by the ASGI server, and the state is added to any subsequent ASGI Requests.
https://asgi.readthedocs.io/en/latest/specs/lifespan.html
This PR implements that final missing link, adds a shallow copy of the state dict to every subsequent ASGI Request, as specified in the ASGI spec.
Fixes Azure/azure-functions-python-worker#1566