Skip to content

Comments

Users/ramacg/add doc and format code#466

Open
ag-ramachandran wants to merge 2 commits intofeature/IngestV2from
users/ramacg/AddDocAndFormatCode
Open

Users/ramacg/add doc and format code#466
ag-ramachandran wants to merge 2 commits intofeature/IngestV2from
users/ramacg/AddDocAndFormatCode

Conversation

@ag-ramachandran
Copy link
Contributor

No description provided.

@github-actions
Copy link

Test Results

530 tests  ±0   521 ✅ ±0   8m 19s ⏱️ -6s
 31 suites ±0     9 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit d6653d7. ± Comparison against base commit bad4866.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Test Results

530 tests  ±0   521 ✅ ±0   8m 55s ⏱️ +30s
 31 suites ±0     9 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit d6653d7. ± Comparison against base commit bad4866.

♻️ This comment has been updated with latest results.

@AsafMah
Copy link
Contributor

AsafMah commented Feb 22, 2026

Can you explain how did you format?
Are there any critical changes?

@@ -0,0 +1,807 @@
# Kusto Ingest-V2 Architecture Documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this document is generated by copilot

To me, it's not very useful - it shows a lot of type hierarchies in a way that is really not helpful for the user.

There is some useful information, but it doesn't explain the basics - what is an source, ingestor, uploader, etc and how they work together.

I think it should be structred as more of a guide, have comparison to v1, and explain why more

- `getOperationSummaryAsync(operation)`: Returns aggregated status counts
- `getOperationDetailsAsync(operation)`: Returns detailed status with individual file/blob details

**Note**: Streaming ingestion operations cannot be tracked. Calling tracking methods on streaming operations will return empty results with a warning.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true for your code? it shouldn't be

In C#, streaming gets the results immediately and saves them inside, so you can call these methods on them and they will work.


**Operation Tracking**:

Queued ingestion returns an `IngestionOperation` that can be used to track the ingestion status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No mention that you need to turn on Operation Tracking via ingestion properties.

Infact, the properties aren't explained or defined anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants