DRY in env code, fix e2e tests

[AsafMah]

Fixed

• Removed calls with account=None, per Remove acquire_token_silent(..., account=None) usage in a backward-compatible way AzureAD/microsoft-authentication-library-for-python#577
• Consistant env variables calling
• Removed hardcoded data from code

[github-actions]

Test Results

    4 files  ±    0      4 suites  ±0   11m 32s ⏱️ + 10m 50s
  35 tests  - 197    35 ✔️  - 193  0 💤  - 1  0 ❌  -   3 
140 runs   - 788  140 ✔️  - 772  0 💤  - 4  0 ❌  - 12 

Results for commit 1f2b00d. ± Comparison against base commit 0d157a6.

This pull request removes 232 and adds 35 tests. Note that renamed tests count towards both.

azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_app_cert_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_app_key_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_async_lock
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_az_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_azure_identity_token_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_base_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_basic_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_callback_token_provider
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_callback_token_provider_with_async_method
azure-kusto-data.tests.aio.test_async_token_providers.TestTokenProvider ‑ test_cloud_mfa_off
…

azure-kusto-data.tests.e2e.TestE2E ‑ test_cloud_info
azure-kusto-data.tests.e2e.TestE2E ‑ test_cloud_info_404
azure-kusto-data.tests.e2e.TestE2E ‑ test_log_analytics_query
azure-kusto-data.tests.e2e.TestE2E ‑ test_log_analytics_query_async
azure-kusto-data.tests.e2e.TestE2E ‑ test_no_redirects_fail_in_client[301]
azure-kusto-data.tests.e2e.TestE2E ‑ test_no_redirects_fail_in_client[302]
azure-kusto-data.tests.e2e.TestE2E ‑ test_no_redirects_fail_in_client[307]
azure-kusto-data.tests.e2e.TestE2E ‑ test_no_redirects_fail_in_client[308]
azure-kusto-data.tests.e2e.TestE2E ‑ test_no_redirects_fail_in_cloud[301]
azure-kusto-data.tests.e2e.TestE2E ‑ test_no_redirects_fail_in_cloud[302]
…

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Merging #489 (1f2b00d) into master (0d157a6) will increase coverage by 0.20%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   70.77%   70.97%   +0.20%     
==========================================
  Files          41       42       +1     
  Lines        3466     3487      +21     
==========================================
+ Hits         2453     2475      +22     
+ Misses       1013     1012       -1     

Files Changed	Coverage Δ
...re-kusto-data/azure/kusto/data/_token_providers.py	54.77% <50.00%> (+0.24%)	⬆️
azure-kusto-data/azure/kusto/data/env_utils.py	95.45% <95.45%> (ø)
...ure-kusto-data/azure/kusto/data/_cloud_settings.py	90.90% <100.00%> (ø)
...zure-kusto-data/azure/kusto/data/client_details.py	77.19% <100.00%> (+0.40%)	⬆️

[yogilad]

Mind these can now be None

[AsafMah]

How? if they don't exist it throws
I don't think you can set an empty env var

[yogilad]

Meaning these had defaults which you omitted from the code

[AsafMah]

Yes, these are defaults in regard to our specific E2E test cluster. Which is very weird, and will fail for anyone who doesn't have the creds for it.
It will continue to work on github because the env is set properly, and also for anyone who configured their e2e tests.

[yogilad]

Approving with suggestion:
Make sure this runs locally and does not go too nuts if local env does not include said env vars (which was the role of the defaults).

[yogilad]

Meaning these had defaults which you omitted from the code