Skip validating MSI in PatchBodyParametersSchema#762
Conversation
AkhilaIlla
requested review from
bdefoy,
mikeharder,
rkmanda,
tejaswiMinnu and
weshaggard
as code owners
|
|
||
| // skip validation for MSI(managed service identity), | ||
| // as it is being referenced from common-types | ||
| if (parameters.schema.description && parameters.schema.description.includes("Managed service identity")) { |
There was a problem hiding this comment.
Shouldn't we think about case-sensitive scenarios? I know we're checking from common-types so it shouldn't change.
But why don't we check the parameter name ("ManagedServiceIdentity") instead of the description? #Resolved
There was a problem hiding this comment.
because its being referenced, the param name wouldnt be available in the schema
There was a problem hiding this comment.
pl use something more deterministic than description. The check should perhaps be done on the properties of the model?
tejaswiMinnu
left a comment
tejaswiMinnu
left a comment
There was a problem hiding this comment.
This branch has some conflicts. Can you take a look and resolve them?
There was a problem hiding this comment.
Please add a brief description to https://github.com/Azure/azure-openapi-validator/blob/main/packages/rulesets/CHANGELOG.md.
I already bumped the version to 2.1.6, so you (or I) can publish 2.1.6 whenever you want these changes to go live.
It needed to merge from main, but I didn't see any conflicts. #Resolved |
|
remember Konrad saying he made some changes which will no longer need these changelogs to be added. In reply to: 2573868553 |
|
I dont see any conflicts. Pulled latest changes too. In reply to: 2573813049 |
|
@rkmanda can you re-review please. In reply to: 2568197148 |
We don't use the |
This reverts commit a592c07.
4 participants
This PR skips validation for MSI(managed service identity) as it is being referenced from common-types & has the required field & is being referenced in patch body parameter schema by several RP's & are having to get an exception. So, skipping to avoid that step.