Skip to content
This repository was archived by the owner on Oct 12, 2023. It is now read-only.

Fix SubscriptionIdReplacer#33

Merged
troydai merged 1 commit intoAzure:masterfrom
lmazuel:fix_subid_replace
Sep 19, 2017
Merged

Fix SubscriptionIdReplacer#33
troydai merged 1 commit intoAzure:masterfrom
lmazuel:fix_subid_replace

Conversation

@lmazuel
Copy link
Member

@lmazuel lmazuel commented Sep 19, 2017

Fix the situation where the body contains something like "/subscriptions/uuid" with no final /

The regexp now follows strictly RFC4122 for UUID definition, which is more predictable than "anything but a slash".

@lmazuel lmazuel requested a review from troydai September 19, 2017 22:18
@msftclas
Copy link

@lmazuel,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link

codecov-io commented Sep 19, 2017

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #33   +/-   ##
======================================
  Coverage    47.3%   47.3%           
======================================
  Files          10      10           
  Lines         389     389           
  Branches       61      61           
======================================
  Hits          184     184           
- Misses        200     201    +1     
+ Partials        5       4    -1
Impacted Files Coverage Δ
...re_devtools/scenario_tests/recording_processors.py 54.71% <100%> (ø) ⬆️
src/azure_devtools/scenario_tests/preparers.py 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddeb1b...8b718a1. Read the comment docs.

@troydai troydai merged commit 708c5ff into Azure:master Sep 19, 2017
@lmazuel lmazuel deleted the fix_subid_replace branch July 6, 2018 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants