This repository was archived by the owner on Oct 12, 2023. It is now read-only.
FIx issue #62 to support float as size_kb in create_temp_file() #63
Merged
haroldrandom merged 6 commits intoAzure:masterfrom Jul 23, 2020
Merged
FIx issue #62 to support float as size_kb in create_temp_file() #63haroldrandom merged 6 commits intoAzure:masterfrom
haroldrandom merged 6 commits intoAzure:masterfrom
Conversation
Juliehzl
changed the title
|
Commenter does not have sufficient privileges for PR 63 in repo Azure/azure-python-devtools |
Member
|
Maybe you can add a description of |
Contributor
Author
sure |
qwordy
suggested changes
Jul 21, 2020
Member
qwordy
left a comment
qwordy
left a comment
There was a problem hiding this comment.
Maybe you can add a description of size_kb to declare that it supports float number.
def create_temp_file(self, size_kb, full_random=False):
qwordy
approved these changes
Jul 21, 2020
haroldrandom
approved these changes
Jul 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #62