Upgrade msal4j to 1.6.1#13216
Conversation
jianghaolu
requested review from
JimSuplizio,
JonathanGiles,
conniey,
danieljurek,
g2vinay,
jialindai,
mitchdenny,
mssfang,
saragluna,
schaabs,
srnagar and
weshaggard
as code owners
…zure#12871) (Azure#13217) Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
jianghaolu
requested review from
alzimmermsft,
amishra-dev,
gapra-msft,
jaschrep-msft and
rickle-msft
as code owners
|
|
||
| ## 1.1.0-beta.1 (Unreleased) | ||
|
|
||
| ## 1.0.9 (2020-07-15) |
There was a problem hiding this comment.
You'll need to change the CHANGELOG date to today otherwise the release pipeline will fail. I'd merge this PR in first and push the update directly to the branch.
There was a problem hiding this comment.
@alzimmermsft, I'm not sure that's the case. @chidozieononiwu updated the changelog verification to only check that there is a date. If you recall "today's date" at around 5-6pm PST is "the next day" on the devops machines.
There was a problem hiding this comment.
Yes @JimSuplizio is right. We loosened up the check so as long as it is a valid date it will work.
There was a problem hiding this comment.
Would it fail if set to a future date? We were planning to ship on Friday but not sure if that will fail the pipeline too.
|
Reviewed offline by @yiliuTo for the spring changes. |
jianghaolu
requested review from
chenrujun,
yiliuTo and
zhoufenqin
as code owners
|
Did you merge from master into your branch before submitting this PR to the release branch? Its gonna carry a lot of baggage with it. |
|
No I didn't. I just migrated the latest eng/common folder. ADO reported the pipeline was incorrectly configured. Bringing the latest eng/common fixed it. |
|
Since this is not master - we can always revert back the eng/common changes as needed. Merging this PR to release identity. |
6 participants
No description provided.