Skip to content

Comments

Generate code for EventHub, ServiceFabric and NotificationHubs#1816

Merged
martinsawicki merged 11 commits intoAzure:masterfrom
RikkiGibson:gen-manager
Jul 19, 2017
Merged

Generate code for EventHub, ServiceFabric and NotificationHubs#1816
martinsawicki merged 11 commits intoAzure:masterfrom
RikkiGibson:gen-manager

Conversation

@RikkiGibson
Copy link
Member

This is mostly gen code. I suggest you review commits that aren't about adding Inners to get a feel for what handwritten code was actually modified and to get a sense of how the new POM and manager generation are working.

Gulpfile has been modified to work with this patch for AutoRest: Azure/autorest#2446

@msftclas
Copy link

@RikkiGibson,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@martinsawicki martinsawicki requested a review from jianghaolu July 17, 2017 22:45
/**
* Entry point to Azure EventHub resource management.
*/
@Beta(Beta.SinceVersion.V1_2_0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use @Beta(SinceVersion.V1_2_0) - I think you can configure this in IntelliJ settings -> editor -> code style -> Java -> Imports -> Insert imports for inner classes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip. The branch has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants