mgmt, add convenience code for DiskEncryptionSet#28936
Merged
XiaofeiCao merged 14 commits intoAzure:mainfrom May 23, 2022
Merged
mgmt, add convenience code for DiskEncryptionSet#28936XiaofeiCao merged 14 commits intoAzure:mainfrom
XiaofeiCao merged 14 commits intoAzure:mainfrom
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
XiaofeiCao
added
Mgmt
XiaofeiCao
commented
May 19, 2022
revert unnecessary changes
Member
weidongxu-microsoft
left a comment
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
overall good, but some details commented.
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Outdated
Show resolved
Hide resolved
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Show resolved
Hide resolved
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Outdated
Show resolved
Hide resolved
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Show resolved
Hide resolved
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
XiaofeiCao
requested review from
ArthurMa1978 and
haolingdong-msft
as code owners
Contributor
Author
|
Need this PR in to fix CI failure. |
Member
|
LGTM. |
haolingdong-msft
approved these changes
May 23, 2022
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Outdated
Show resolved
Hide resolved
...anager-compute/src/main/java/com/azure/resourcemanager/compute/models/DiskEncryptionSet.java
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #27966
doc on disk encryption set: https://docs.microsoft.com/en-us/azure/virtual-machines/disk-encryption
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines