Skip to content

[Key Vault] Adding error logging for when downloading an HSM's security domain fails.#29175

Merged
vcolin7 merged 1 commit intomainfrom
vcolin7-hsm-sd-error-logging
Jun 7, 2022
Merged

[Key Vault] Adding error logging for when downloading an HSM's security domain fails.#29175
vcolin7 merged 1 commit intomainfrom
vcolin7-hsm-sd-error-logging

Conversation

@vcolin7
Copy link
Member

@vcolin7 vcolin7 commented Jun 1, 2022

Description

Downloading an HSM's Security domain sometimes fails for our live tests without us logging a possible error message from the Powershell cmdlet. This PR attempts to align Java with .NET to alleviate this.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@vcolin7 vcolin7 added KeyVault Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Jun 1, 2022
@vcolin7 vcolin7 added this to the [2022] June milestone Jun 1, 2022
@vcolin7 vcolin7 requested a review from heaths June 1, 2022 23:49
@vcolin7 vcolin7 requested a review from g2vinay as a code owner June 1, 2022 23:49
@vcolin7 vcolin7 self-assigned this Jun 1, 2022
@vcolin7 vcolin7 requested a review from samvaity as a code owner June 1, 2022 23:49
@vcolin7 vcolin7 changed the title Adding error logging for when downloading an HSM's security domain fails. [Key Vault] Adding error logging for when downloading an HSM's security domain fails. Jun 1, 2022
@check-enforcer
Copy link

check-enforcer bot commented Jun 2, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@vcolin7
Copy link
Member Author

vcolin7 commented Jun 2, 2022

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vcolin7
Copy link
Member Author

vcolin7 commented Jun 7, 2022

/check-enforcer override

@vcolin7 vcolin7 merged commit 2f9cd5d into main Jun 7, 2022
@vcolin7 vcolin7 deleted the vcolin7-hsm-sd-error-logging branch June 7, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault test-reliability Issue that causes tests to be unreliable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants