[Amqp] Moving tests using VirtualTimeScheduler to dedicated test classes to run them in sequential and isolated mode#29492
Merged
kasobol-msft merged 4 commits intoAzure:mainfrom Jun 15, 2022
Conversation
…r running them in sequential/isolated
anuchandy
requested review from
JonathanGiles,
ZejiaJiang,
conniey,
haolingdong-msft,
ki1729,
liukun-msft,
srnagar and
weidongxu-microsoft
as code owners
ghost
added
the
alzimmermsft
approved these changes
Jun 15, 2022
Member
alzimmermsft
left a comment
alzimmermsft
left a comment
There was a problem hiding this comment.
Just need to add license headers
Collaborator
|
API change check API changes are not detected in this pull request. |
kasobol-msft
approved these changes
Jun 15, 2022
Contributor
kasobol-msft
left a comment
kasobol-msft
left a comment
There was a problem hiding this comment.
@anuchandy can you put link to this PR in https://github.com/Azure/azure-sdk-for-java/wiki/Unit-Testing#stepverifierwithvirtualtime as reference implementation of isolation?
Member
Author
|
Good point Kamil, will do it. |
khmic5
pushed a commit
to daniel-rocha/azure-sdk-for-java
that referenced
this pull request
Jun 19, 2022
…ses to run them in sequential and isolated mode (Azure#29492) * Creating dedicated test class for tests using VirtualTimeScheduler for running them in sequential/isolated * Adding license header * Isolating ReactorReceiver test using VTS * fixing checkstyle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/Azure/azure-sdk-for-java/wiki/Unit-Testing#stepverifierwithvirtualtime for the reason to make this change.