Skip to content

Comments

Adding NOT CONTAINS support to Criteria Queries.#30379

Merged
trande4884 merged 4 commits intoAzure:mainfrom
trande4884:trande_notcontains
Aug 11, 2022
Merged

Adding NOT CONTAINS support to Criteria Queries.#30379
trande4884 merged 4 commits intoAzure:mainfrom
trande4884:trande_notcontains

Conversation

@trande4884
Copy link
Member

@trande4884 trande4884 commented Aug 10, 2022

Description

Adding NOT CONTAINS support to Criteria Queries.
Adding unit tests for NOT CONTAINS and CONTAINS since they did not exist.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Adding unit tests for NOT CONTAINS and CONTAINS since they did not exist.
@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @trande4884 for this new feature.

@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884 trande4884 requested a review from chenrujun as a code owner August 11, 2022 14:10
@trande4884
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trande4884
Copy link
Member Author

Develop a presentation on something you have been working on and present to the team
Record the meeting and upload the recording or a link to the recording to this ticket
Upload any additional resources to this ticket (slides, ect.)

@trande4884 trande4884 merged commit b59e98e into Azure:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues Cosmos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cosmos - Is there a prescribed way to build a query for 'Not Contains'?

2 participants