Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
anuchandy
reviewed
May 3, 2023
...azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ReceiverOptions.java
Outdated
Show resolved
Hide resolved
...ssaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusClientBuilder.java
Outdated
Show resolved
Hide resolved
...saging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusSessionManager.java
Outdated
Show resolved
Hide resolved
...cebus/src/main/java/com/azure/messaging/servicebus/ServiceBusSessionReceiverAsyncClient.java
Outdated
Show resolved
Hide resolved
lmolkova
force-pushed
the
addSessionIdleTimeout
branch
from
9ba4058 to
5052ac7
Compare
lmolkova
requested review from
JonathanGiles,
alzimmermsft,
billwert,
mssfang,
srnagar and
vcolin7
as code owners
anuchandy
approved these changes
May 3, 2023
Member
anuchandy
left a comment
anuchandy
left a comment
There was a problem hiding this comment.
looks great to me, thank you!
...azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ReceiverOptions.java
Outdated
Show resolved
Hide resolved
...saging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusSessionManager.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34667