Skip to content

Support multiple Spring version integration tests#41170

Merged
moarychan merged 34 commits intoAzure:mainfrom
moarychan:moary/support-multiple-spring-versions-for-integration-tests
Jul 24, 2024
Merged

Support multiple Spring version integration tests#41170
moarychan merged 34 commits intoAzure:mainfrom
moarychan:moary/support-multiple-spring-versions-for-integration-tests

Conversation

@moarychan
Copy link
Member

Description

Support multiple Spring version integration tests based on configuration file spring-cloud-azure-supported-spring.json.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jul 17, 2024
@moarychan
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moarychan
Copy link
Member Author

/azp run java - spring - tests

1 similar comment
@moarychan
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moarychan moarychan marked this pull request as ready for review July 17, 2024 05:49
@moarychan
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@moarychan
Copy link
Member Author

Hi @JimSuplizio, @benbp, @hallipr, @weshaggard, can any of you please review this PR? Thanks in advance!

…edentialUnavailableException: Encountered error when deserializing response from Azure Power Shell
@moarychan moarychan marked this pull request as draft July 22, 2024 01:16
@JimSuplizio JimSuplizio requested a review from alzimmermsft July 22, 2024 16:47
@JimSuplizio
Copy link
Contributor

@moarychan, I'm adding @alzimmermsft in case he has any feedback. I am going to say that it's kind of hard to review a PR considering the state of the java - spring - tests pipeline results are indicative of something catastrophic going on. I cannot approve these changes at this time.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@moarychan moarychan marked this pull request as draft July 23, 2024 07:50
@moarychan moarychan marked this pull request as ready for review July 23, 2024 10:27
@moarychan
Copy link
Member Author

Now Spring tests run almost completely successfully, I will re-run the failed one, @JimSuplizio and @alzimmermsft, please help review. Many thanks!

Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with the eng changes.

@benbp
Copy link
Member

benbp commented Jul 23, 2024

I will review this today

@moarychan
Copy link
Member Author

/check-enforcer override

@moarychan moarychan merged commit 98825bb into Azure:main Jul 24, 2024
@moarychan moarychan deleted the moary/support-multiple-spring-versions-for-integration-tests branch August 2, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants