Add Testcontainers Service Connection support for Cosmos, Blob and Queue by rujche · Pull Request #41176 · Azure/azure-sdk-for-java

rujche · 2024-07-17T07:02:52Z

Description

ConnectionDetails and Service Connection support have been added for Cosmos, Storage Blob and Storage Queue.

Currently, Cosmos can be used with Testcontainers only using Gateway Mode. See testcontainers/testcontainers-java#5518

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

Fixes spring-projects/spring-boot#40329

azure-sdk · 2024-07-17T07:53:55Z

API change check

API changes are not detected in this pull request.

sdk/spring/scripts/compatibility_update_supported_version_matrix_json.py

...va/com/azure/spring/cloud/autoconfigure/implementation/cosmos/CosmosClientConfiguration.java

...cloud/autoconfigure/implementation/cosmos/properties/AzureCosmosPropertiesConfiguration.java

...ing/cloud/autoconfigure/implementation/cosmos/properties/ConfigurationWithClassWithBean.java

.../cloud/autoconfigure/implementation/cosmos/properties/ConfigurationWithClassWithoutBean.java

azure-sdk · 2024-07-17T08:40:33Z

API change check

API changes are not detected in this pull request.

2. Move conditionalOnClass to upper configuration class.

rujche · 2024-07-17T09:57:27Z

/azp run java - spring - tests

azure-pipelines · 2024-07-17T09:57:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2024-07-17T10:01:18Z

API change check

API changes are not detected in this pull request.

rujche · 2024-07-18T02:09:31Z

/azp run java - spring - tests

azure-pipelines · 2024-07-18T02:09:52Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2024-07-18T02:12:10Z

API change check

API changes are not detected in this pull request.

This reverts commit 4ef5581.

rujche · 2024-07-18T06:22:14Z

/azp run java - spring - tests

azure-pipelines · 2024-07-18T06:22:37Z

Azure Pipelines successfully started running 1 pipeline(s).

…nfiguration.

rujche · 2024-07-18T09:19:27Z

/azp run java - spring - tests

azure-pipelines · 2024-07-18T09:19:48Z

Azure Pipelines successfully started running 1 pipeline(s).

rujche · 2024-07-18T14:25:35Z

/azp run java - spring - tests

azure-pipelines · 2024-07-18T14:25:59Z

Azure Pipelines successfully started running 1 pipeline(s).

rujche · 2024-07-18T14:40:08Z

/azp run java - spring - tests

azure-pipelines · 2024-07-18T14:40:32Z

Azure Pipelines successfully started running 1 pipeline(s).

rujche · 2024-07-20T06:04:57Z

Hi, @saragluna .

Please help to review this PR.

I created another PR to fix the live test failure: #41221

saragluna

LGTM

...zure/spring/cloud/autoconfigure/implementation/cosmos/AzureCosmosAutoConfigurationTests.java

rujche · 2024-07-22T07:25:30Z

/azp run java - spring - tests

azure-pipelines · 2024-07-22T07:25:51Z

Azure Pipelines successfully started running 1 pipeline(s).

rujche · 2024-07-22T09:29:27Z

Hi, @saragluna .

Please help to approve this PR again.

Add Testcontainers Service Connection support for Cosmos, Blob and Queue

9a868a0

rujche requested review from JonathanGiles, Netyyyy, alzimmermsft, g2vinay, moarychan, samvaity and saragluna as code owners July 17, 2024 07:02

github-actions bot added the azure-spring All azure-spring related issues label Jul 17, 2024

rujche mentioned this pull request Jul 17, 2024

Add Testcontainers Service Connection support for Cosmos, Blob and Queue #40388

Closed

6 tasks

rujche added 2 commits July 17, 2024 16:28

Fix pipeline failure by deleting "annotation-process".

80bce4e

Merge branch 'main' into support-test-container

c22bf67

saragluna reviewed Jul 17, 2024

View reviewed changes

rujche added 2 commits July 17, 2024 17:27

1. Remove "public" for classes only used inside package.

42f92fe

2. Move conditionalOnClass to upper configuration class.

Merge WithoutClass and WithClassWithoutBean.

603afcd

Add classes in @EnableConfigurationProperties.

4ef5581

rujche added 2 commits July 18, 2024 13:44

Revert "Add classes in @EnableConfigurationProperties."

0986b4b

This reverts commit 4ef5581.

Fix test failures.

f92b5be

Fix test failure by adding @ConditionalOnProperty on CosmosDataAutoCo…

d437e49

…nfiguration.

Fix test failure by adding @ConditionalOnDatabaseConfigured.

5821875

Fix error reported by maven-checkstyle-plugin.

de90082

rujche closed this Jul 20, 2024

rujche deleted the support-test-container branch July 20, 2024 07:31

rujche restored the support-test-container branch July 20, 2024 07:42

rujche reopened this Jul 20, 2024

saragluna reviewed Jul 22, 2024

View reviewed changes

...zure/spring/cloud/autoconfigure/implementation/cosmos/AzureCosmosAutoConfigurationTests.java Show resolved Hide resolved

Merge branch 'main' into support-test-container

1ccca90

saragluna approved these changes Jul 22, 2024

View reviewed changes

rujche merged commit 68942de into Azure:main Jul 22, 2024

rujche deleted the support-test-container branch July 22, 2024 09:58

rujche self-assigned this Jul 31, 2024

rujche added this to the 2024-08 milestone Jul 31, 2024

rujche linked an issue Jul 31, 2024 that may be closed by this pull request

[FEATURE REQ] Add @ServiceConnection support for CosmosDB, EventHub and Azurite #40329

Closed

2 tasks

rujche mentioned this pull request Mar 11, 2026

[FEATURE REQ] Support TestContainers and Docker Compose in Spring Cloud Azure 4.x #48377

Closed

Copilot AI mentioned this pull request Mar 11, 2026

[WIP] Sync TestContainers and Docker Compose features for Spring Cloud Azure #48378

Closed

Conversation

rujche commented Jul 17, 2024

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

azure-sdk commented Jul 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Jul 17, 2024

Uh oh!

rujche commented Jul 17, 2024

Uh oh!

azure-pipelines bot commented Jul 17, 2024

Uh oh!

azure-sdk commented Jul 17, 2024

Uh oh!

rujche commented Jul 18, 2024

Uh oh!

azure-pipelines bot commented Jul 18, 2024

Uh oh!

azure-sdk commented Jul 18, 2024

Uh oh!

rujche commented Jul 18, 2024

Uh oh!

azure-pipelines bot commented Jul 18, 2024

Uh oh!

rujche commented Jul 18, 2024

Uh oh!

azure-pipelines bot commented Jul 18, 2024

Uh oh!

rujche commented Jul 18, 2024

Uh oh!

azure-pipelines bot commented Jul 18, 2024

Uh oh!

rujche commented Jul 18, 2024

Uh oh!

azure-pipelines bot commented Jul 18, 2024

Uh oh!

rujche commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saragluna left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rujche commented Jul 22, 2024

Uh oh!

azure-pipelines bot commented Jul 22, 2024

Uh oh!

rujche commented Jul 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rujche commented Jul 20, 2024 •

edited

Loading