Skip to content

Add Storage Blob and Queue Service Connection from Docker Compose#41321

Merged
rujche merged 16 commits intoAzure:mainfrom
eddumelendez:docker-compose-service-connection
Aug 29, 2024
Merged

Add Storage Blob and Queue Service Connection from Docker Compose#41321
rujche merged 16 commits intoAzure:mainfrom
eddumelendez:docker-compose-service-connection

Conversation

@eddumelendez
Copy link
Copy Markdown
Contributor

Description

Spring Boot also provides Service Connection from Docker Compose. This contribution adds support for Storage Blob and Storage Queue.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jul 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution @eddumelendez! We will review the pull request and get back to you soon.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jul 27, 2024
@rujche rujche force-pushed the docker-compose-service-connection branch from d289558 to ecee254 Compare July 31, 2024 02:04
@rujche rujche added this to the 2024-09 milestone Jul 31, 2024
@rujche
Copy link
Copy Markdown
Member

rujche commented Jul 31, 2024

Hi, @eddumelendez

Thanks for your contributing.

  1. I updated the PR, please take a look.
  2. Do you have plan about implementing CosmosDockerComposeConnectionDetailsFactory.
  • For spring-cloud-azure-docker-container, it has dependency of org.springframework.boot:spring-boot-test-containers and org.testcontainers:azure.
    • ContainerConnectionDetailsFactory in spring-boot-test-containers has type parameter C extends Container<?>, so CosmosDBEmulatorContainer in org.testcontainers.azure can be used.
    • In unit test, trust store related property like javax.net.ssl.trustStore can be built by CosmosDBEmulatorContainer.
  • For spring-cloud-azure-docker-compose, now it doesn't have any dependency about testcontainer. Seems xxx-docker-compose is not related with testcontainer related dependencies, it's not right to add org.testcontainers.azure dependency in spring-cloud-azure-docker-compose.

@eddumelendez
Copy link
Copy Markdown
Contributor Author

Hi @rujche

Thanks for updating the PR.

CosmosDBEmulatorContainer is already supported in spring-cloud-azure-testcontainers. See CosmosContainerConnectionDetailsFactory

Regarding to docker-compose not sure yet how to handle the certificate.

@rujche rujche linked an issue Jul 31, 2024 that may be closed by this pull request
2 tasks
@rujche
Copy link
Copy Markdown
Member

rujche commented Aug 4, 2024

Hi, @saragluna , please help to review this PR. Let's support Storage Blob and Queue first. Support Cosmos in another PR.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@rujche rujche merged commit 1996889 into Azure:main Aug 29, 2024
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request Sep 23, 2024
@rujche
Copy link
Copy Markdown
Member

rujche commented Feb 10, 2026

Hi @rujche

Thanks for updating the PR.

CosmosDBEmulatorContainer is already supported in spring-cloud-azure-testcontainers. See CosmosContainerConnectionDetailsFactory

Regarding to docker-compose not sure yet how to handle the certificate.

Link to related test PR: #47958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add @ServiceConnection support for CosmosDB, EventHub and Azurite

4 participants