You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is upgrading Reactor dependencies from 3.4.41 to 3.7.1 and Reactor Netty from 1.0.48 to 1.2.1. This is being done as the previous Reactor and Reactor Netty minor versions, 3.4.x and 1.0.x respectively, are end of life and no longer receiving updates.
The Azure SDKs will continue to perform version validation tests using Reactor versions 3.4.15, 3.5.0, and 3.6.0 and Reactor Netty versions 1.0.0 and 1.1.0 to ensure a baseline compatibility with common ecosystems such as Spring which leverage Reactor as well.
Looking forward into the future, eventually validation for Reactor 3.4.15 and Reactor Netty 1.0.0 can be dropped once Spring Framework 5.3 and Spring Boot 2.7 reach end of life for commercial support.
Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Looking at this PR and the current version being 1.0.48 I see no way to fix this from the outside with a version constraint. This needs to be fixed in the Azure SDK.
reactor-netty-http upgrade to 1.2.8 is breaking the webclient calls. It is working till 1.2.7.
error - "text":"Failed to initialize a channel. Closing: [id: 0x8cbd0444]","details":null},"thread":"reactor-http-nio-3","pid":"24124","correlation-id":"","trace":"","errorcode":"",
"stacktrace":"<#693c1b68> j.l.NoSuchMethodError: 'void io.netty.handler.codec.http.HttpContentDecompressor.(boolean,
Hi! There's a fix version 1.0.49 but it seems it's only available in the spring commercial license. Is there a way to update and use that one? check here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is upgrading Reactor dependencies from
3.4.41to3.7.1and Reactor Netty from1.0.48to1.2.1. This is being done as the previous Reactor and Reactor Netty minor versions,3.4.xand1.0.xrespectively, are end of life and no longer receiving updates.The Azure SDKs will continue to perform version validation tests using Reactor versions
3.4.15,3.5.0, and3.6.0and Reactor Netty versions1.0.0and1.1.0to ensure a baseline compatibility with common ecosystems such as Spring which leverage Reactor as well.Looking forward into the future, eventually validation for Reactor
3.4.15and Reactor Netty1.0.0can be dropped once Spring Framework 5.3 and Spring Boot 2.7 reach end of life for commercial support.And possibly other versions could be dropped as well depending on ecosystem support for them in maintained versions.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines