Sync eng/common directory with azure-sdk-tools for PR 14973

[azure-sdk]

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14973 See eng/common workflow

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Syncs eng/common with updates from azure-sdk-tools PR 14973, adding special-case cleanup for VLW (Versioned-Level WORM) containers to ensure storage container/account deletion succeeds when versioning + soft-delete leave behind non-current versions.

Changes:

• Add VLW-aware blob cleanup path during storage account removal.
• Introduce Remove-VlwContainerBlobs to enumerate and delete blob versions / soft-deleted blobs and clear holds/policies.

[Copilot]

Get-Member is relatively expensive and is executed once per container in the deletion loop. Prefer a property existence check via PSObject.Properties (or equivalent) instead of Get-Member so this scales better when many containers are present.

[Copilot]

Using -ErrorAction SilentlyContinue here can mask real failures (auth/permission issues, transient storage errors). If listing fails, $blobs becomes empty and the function will silently stop, likely leaving the container undeletable. Recommend handling errors explicitly (e.g., capture and emit a warning/error) so the caller has actionable diagnostics when cleanup cannot proceed.

Suggested change

	$blobs = @($Container | Get-AzStorageBlob -IncludeVersion -IncludeDeleted -ErrorAction SilentlyContinue)
	try {
	$blobs = @($Container | Get-AzStorageBlob -IncludeVersion -IncludeDeleted -ErrorAction Stop)
	} catch {
	Write-Error "Failed to list blobs for VLW container '$($Container.Name)' in storage account '$StorageAccountName', resource group '$ResourceGroupName'. Cleanup cannot continue. $($_.Exception.Message)"
	throw
	}

[Copilot]

The hard-coded max pass count (5) is a magic number that’s difficult to tune if behavior changes. Consider making it a parameter with a default (or at least a named constant) and, if the limit is reached while still finding blobs, return/throw a clear failure so the caller knows cleanup may be incomplete.

[Copilot]

Write-Host is difficult to control in CI logs (can’t be suppressed via standard preference variables and can be noisy). Prefer Write-Verbose/Write-Information (or whatever this script uses elsewhere) so callers can opt into detailed logging without always emitting host output.

Suggested change

	Write-Host "Cleaning VLW container '$($Container.Name)' versions and soft-deleted blobs in account '$StorageAccountName', group: $ResourceGroupName"
	Write-Verbose "Cleaning VLW container '$($Container.Name)' versions and soft-deleted blobs in account '$StorageAccountName', group: $ResourceGroupName"