-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Closed
Labels
Azure.CoreClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.feature-requestThis issue requires a new behavior in the product in order be resolved.This issue requires a new behavior in the product in order be resolved.
Milestone
Description
When doing a call like this:
request = self._client.get(url, query_parameters, header_parameters)We are coming here:
azure-sdk-for-python/sdk/core/azure-core/azure/core/pipeline/transport/_base.py
Lines 288 to 305 in 194ae8d
| def format_parameters(self, params): | |
| # type: (Dict[str, str]) -> None | |
| """Format parameters into a valid query string. | |
| It's assumed all parameters have already been quoted as | |
| valid URL strings. | |
| :param dict params: A dictionary of parameters. | |
| """ | |
| query = urlparse(self.url).query | |
| if query: | |
| self.url = self.url.partition("?")[0] | |
| existing_params = { | |
| p[0]: p[-1] for p in [p.partition("=") for p in query.split("&")] | |
| } | |
| params.update(existing_params) | |
| query_params = ["{}={}".format(k, v) for k, v in params.items()] | |
| query = "?" + "&".join(query_params) | |
| self.url = self.url + query |
We should accept a list of string as params for instance {'a':['b','c']}, and explode the parameters in that case: a=b&a=c
FYI @johanste
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Azure.CoreClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.feature-requestThis issue requires a new behavior in the product in order be resolved.This issue requires a new behavior in the product in order be resolved.