_convert_query_string return a wrong query string parameter

[kahwooi]

_convert_query_string return a wrong query string parameter. 'sr=b' is return as 'resource=b' :

Code :

    accss_plcy = AccessPolicy()
    accss_plcy.start = '2013-03-12'
    accss_plcy.expiry = '2013-03-13'
    accss_plcy.permission = 'r'
    signed_identifier = 'YWJjZGVmZw=='
    sap = SharedAccessPolicy(accss_plcy, signed_identifier)
    qry_str = sas.generate_signed_query_string('picture/xxx.jpg','b', sap)
    return sas._convert_query_string(qry_str)

Result:
st=2013-03-12&se=2013-03-13&sp=r&resource=blob&sig=FI88prUINf58Seg5Nwo6Uj5RP9FxXGZBBSKi7pybmeQ=&

Solution:
Change the code at line 129 of file src/azure/storage/sharedaccesssignature.py to :

   convert_str += SIGNED_RESOURCE + '=' + query_string[SIGNED_RESOURCE] + '&'

[huguesv]

We'll look into this. Thanks for letting us know!

[huguesv]

The resource type constants were also wrong, blob should be 'b', not 'blob', and the same for container. And the url that we create should quote the signature, as it has + and = in it. Docs on shared signature are at:
http://msdn.microsoft.com/en-us/library/windowsazure/ee395415.aspx

[kahwooi]

Can I have the sample code for share key generation. Python for azure is lacking of documentation.

[schallis]

I'm also having trouble with this code, even after making the modification for the type constants:

curl -X PUT -t Bonsai.gif -H 'x-ms-date: 2013-03-20' -H \
    'Content-Length: 1444' \
    'http://<myaccount>.blob.core.windows.net/testcontainer/Bonsai.gif?st=2013-03-20T17:33:55.077788&se=2013-03-20T18:04:00.077844&sp=rwdl&sr=b&sig=j584FDGR0KwyK/qoSGVVH6/V3yBxtFexwkUOFfEQ/qk=&'

returns:

<?xml version="1.0" encoding="utf-8"?>
<Error>
    <Code>AuthenticationFailed</Code>
    <Message>Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.
    RequestId:da42a551-6a09-48f5-814d-5204782441aa
    Time:2013-03-20T17:34:12.7340721Z</Message>
    <AuthenticationErrorDetail>Signature fields not well formed.</AuthenticationErrorDetail>
</Error>

Calling urllib.quote on line 101 for the signature hasn't helped.

[huguesv]

I have fixes coming in as soon as they have been code reviewed. I have added tests to test_blobservice.py that show how to use the shared access signature (test_shared_access_blob, test_shared_access_container).

These fixes are currently only in my fork, please have a look and let me know if you try it out. If everything goes well, this should get pushed to the main repo and pypi tomorrow.

url to the branch is:
https://github.com/huguesv/azure-sdk-for-python/tree/bugfixes

commit for shared access signature changes:
https://github.com/huguesv/azure-sdk-for-python/commit/a7ac10a13ed2d11a229ef9602759666223feb946

[schallis]

The docs appear to require the sv parameter which isn't being generated - http://msdn.microsoft.com/en-us/library/windowsazure/hh508996.aspx

[schallis]

Ok so I noticed I was passing the date in as ISO 8601 (from the Python isoformat() function) as opposed to the ISO 8061 format needed for Azure. Doh!

The newest bugfix branch is working for me though.

[huguesv]

Fixes are checked in and package on PyPI has been updated (v0.6.2).