Keep alive associated AMQP links via Service Bus management requests.#10209
Merged
KieranBrantnerMagee merged 2 commits intoAzure:masterfrom Mar 11, 2020
Conversation
…hat they actually keep the underlying primary link alive as well. Prior to this change, links would be force disconnected by the service after 10 minutes idle, even if autorenew/keep-alive were present.
KieranBrantnerMagee
added
Service Bus
Client
|
Can one of the admins verify this patch? |
…rlier evaluation. Turn associated-link-name into a constant.
yunhaoling
approved these changes
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the "associated-link-name" parameter to management requests so that they actually keep the primary sender/receiver link alive as well.
Prior to this change, links would be force disconnected by the service after 10 minutes idle, even if autorenew/keep-alive were present.
Also contains a stress test to validate this scenario before and after the change. (Did a stress test in leiu of a unit test because the failure requires a 10 minute wall-time delay to trigger the service force disconnect)
Should address #10127 so long as user enables an AutoLockRenew to be running (e.g. against the message in question) or calls renew() themselves within the expiry window.