[Azure-Core]Auth Header missing when token credential is not expired#11171
Closed
xiafu-msft wants to merge 1 commit intoAzure:masterfrom
Closed
[Azure-Core]Auth Header missing when token credential is not expired#11171xiafu-msft wants to merge 1 commit intoAzure:masterfrom
xiafu-msft wants to merge 1 commit intoAzure:masterfrom
Conversation
rakshith91
reviewed
May 1, 2020
sdk/core/azure-core/azure/core/pipeline/policies/_authentication.py
Outdated
Show resolved
Hide resolved
xiafu-msft
requested review from
amishra-dev,
annatisch and
zezha-msft
as code owners
rakshith91
reviewed
May 1, 2020
| if self._need_new_token: | ||
| self._token = self._credential.get_token(*self._scopes) | ||
| self._update_headers(request.http_request.headers, self._token.token) | ||
| self._update_headers(request.http_request.headers, self._token.token) # ignore |
Contributor
There was a problem hiding this comment.
should be # type: ignore
Member
|
@xiafu-msft I extended your PR in #11177 (I cherry-picked your commit in it), but I added unittests as well. Closing this one then, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.