[do not merge] update OSName to OSVmName#11393
Conversation
scbedd
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
scbedd
changed the title
| TestMatrix: | ||
| Linux_Python27: | ||
| OSName: 'Linux' | ||
| OSVmName: 'Linux' |
There was a problem hiding this comment.
Once we resolve Azure/azure-sdk-tools#610 (comment) we should be able to simply remove the OSName from all the matrix entries.
|
The shared template from eng/common has just been merged #11417 so this PR can now be updated to remove OSName everywhere and use that template. |
|
fyi @chidozieononiwu |
| inputs: | ||
| testResultsFiles: '**/junit/test-results.xml' | ||
| testRunTitle: '$(OSName) Python $(PythonVersion)' | ||
| testRunTitle: '$(OSVmName) Python $(PythonVersion)' |
There was a problem hiding this comment.
You should leave this as $(OSName) since it will be set by the verify-agent-os.yml script here
| RunForPR: true | ||
| Linux_Python35: | ||
| OSName: 'Linux' | ||
| OSVmName: 'Linux' |
There was a problem hiding this comment.
We are just removing this completely for all the matrix entries.
There was a problem hiding this comment.
We use it when publishing the test run title, so I'm going to keep the parameter around (just renamed).
I should just be able to remove the parameter being passed to the common yml yes?
There was a problem hiding this comment.
It will be set within the script. So I think you don't need the variable at all, so long as the verify-agent-os script runs a s the first step. it is set here
| AfterTestSteps: ${{ parameters.AfterTestSteps }} | ||
| PythonVersion: $(PythonVersion) | ||
| OSName: $(OSName) | ||
| OSVmName: $(OSVmName) |
There was a problem hiding this comment.
You should just remove this parameter as its no longer required.
| - template: eng/pipelines/templates/scripts/verify-agent-os.yml@azure-sdk-tools | ||
| parameters: | ||
| OSName: ${{ parameters.OSName }} | ||
| OSName: ${{ parameters.OSVmName }} |
|
Being executed through eng/common. Closing. |
Adding API to support generating access token for ApplicationInsights Profiler (Azure#11393) * Adds base for updating Microsoft.Insights from version preview/2020-10-05-preview to version 2020-10-26-preview * Updates readme * Updates API version in new specs and examples * Update readme to pointing to profilerToken_API.json * Update operations list * Add profiler token getter * Wire up the defintions * Fix error: additonal property of liveToken * Append post action * Update api-version for example * Fix some small issues * Update readme for the resolving autorest check issue * From profilertoken to profilerToken * Ran prettier * Appending back missing readme for 2020-10 tag * Fix some mistakes * Use common error response * Tag secret with x-ms-secret * Remove list operations * Clean up packages * Making 2 post operations for token * Remove unused operations_list.json example * Align with official master * Resolve conflicts * Add x-ms-secret for the token * Update error response schema ref * Update operation ids * Remove unused error response
4 participants
Use the common script. It looks like Matrix usage isn't supported any longer.
PLAN CHANGE. This will take advantage of eng/common. This PR should not merge.