Skip to content

Prevent test failure due to operation timing #11552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 1 commit into from
May 20, 2020
Merged

Prevent test failure due to operation timing #11552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,13 +208,15 @@ def test_crud_operations(self, client, **kwargs):
cert = client.get_certificate(certificate_name=cert_name)
self._validate_certificate_bundle(cert=cert, cert_name=cert_name, cert_policy=cert_policy)

# update certificate
# update certificate, ensuring the new updated_on value is at least one second later than the original
if self.is_live:
time.sleep(1)
tags = {"tag1": "updated_value1"}
cert_bundle = client.update_certificate_properties(cert_name, tags=tags)
self._validate_certificate_bundle(cert=cert_bundle, cert_name=cert_name, cert_policy=cert_policy)
self.assertEqual(tags, cert_bundle.properties.tags)
self.assertEqual(cert.id, cert_bundle.id)
self.assertNotEqual(cert.properties.updated_on, cert_bundle.properties.updated_on)
updated_cert = client.update_certificate_properties(cert_name, tags=tags)
self._validate_certificate_bundle(cert=updated_cert, cert_name=cert_name, cert_policy=cert_policy)
self.assertEqual(tags, updated_cert.properties.tags)
self.assertEqual(cert.id, updated_cert.id)
self.assertNotEqual(cert.properties.updated_on, updated_cert.properties.updated_on)

# delete certificate
delete_cert_poller = client.begin_delete_certificate(cert_name)
Expand Down
14 changes: 8 additions & 6 deletions sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,15 @@ async def test_crud_operations(self, client, **kwargs):
cert = await client.get_certificate(certificate_name=cert_name)
self._validate_certificate_bundle(cert=cert, cert_name=cert_name, cert_policy=cert_policy)

# update certificate
# update certificate, ensuring the new updated_on value is at least one second later than the original
if self.is_live:
await asyncio.sleep(1)
tags = {"tag1": "updated_value1"}
cert_bundle = await client.update_certificate_properties(cert_name, tags=tags)
self._validate_certificate_bundle(cert=cert_bundle, cert_name=cert_name, cert_policy=cert_policy)
self.assertEqual(tags, cert_bundle.properties.tags)
self.assertEqual(cert.id, cert_bundle.id)
self.assertNotEqual(cert.properties.updated_on, cert_bundle.properties.updated_on)
updated_cert = await client.update_certificate_properties(cert_name, tags=tags)
self._validate_certificate_bundle(cert=updated_cert, cert_name=cert_name, cert_policy=cert_policy)
self.assertEqual(tags, updated_cert.properties.tags)
self.assertEqual(cert.id, updated_cert.id)
self.assertNotEqual(cert.properties.updated_on, updated_cert.properties.updated_on)

# delete certificate
deleted_cert_bundle = await client.delete_certificate(certificate_name=cert_name)
Expand Down