DefaultAzureCredential configures InteractiveBrowserCredential's tenant#11662
Merged
chlowell merged 1 commit intoAzure:masterfrom May 27, 2020
Merged
DefaultAzureCredential configures InteractiveBrowserCredential's tenant#11662chlowell merged 1 commit intoAzure:masterfrom
chlowell merged 1 commit intoAzure:masterfrom
Conversation
chlowell
added
Client
xiangyan99
approved these changes
May 27, 2020
Member
xiangyan99
left a comment
xiangyan99
left a comment
There was a problem hiding this comment.
The code looks good. Just wanted to confirm the kwarg name 'interactive_browser_tenant_id' not 'tenant_id'?
Member
Author
|
Yes, the virtues of "interactive_browser_tenant_id" are that it's consistent with our .NET API, clearly indicates where it will apply, and follows the existing pattern of allowing different tenant IDs for different credentials. "tenant_id" suggests it would apply to all credentials. |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 27, 2020
…into models_to_submodels * 'master' of https://github.com/Azure/azure-sdk-for-python: Increment package version after release of azure_ai_textanalytics (Azure#11664) DefaultAzureCredential can configure InteractiveBrowserCredential's tenant (Azure#11662) use CIMultiDict when pickling (Azure#11661) [text analytics] update version to b6 (Azure#11660)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, when
DefaultAzureCredentialauthenticates a user throughInteractiveBrowserCredential, it always authenticates that user in the "organizations" tenant, i.e. that user's home tenant. This PR enables changing that behavior by specifying a tenant through environment variableAZURE_TENANT_IDor a keyword argument toDefaultAzureCredential,interactive_browser_tenant_id(this matches what we have in our .NET library).Closes #11548