Conversation
KarishmaGhiya
commented
Jul 23, 2020
KarishmaGhiya
commented
- update swagger that generates the links
- do not update yaml files
KarishmaGhiya
requested review from
KieranBrantnerMagee,
YijunXieMS,
aim-for-better,
amishra-dev,
annatisch,
bgklein,
chlowell,
danieljurek,
idear1203,
iscai-msft,
johanste,
kristapratico,
lmazuel,
mayurid,
mitchdenny,
rakshith91,
scbedd,
schaabs,
southpolesteve,
weshaggard,
xiafu-msft,
xiangyan99,
xingwu1,
yunhaoling,
zezha-msft,
zfoster and
zikalino
as code owners
|
Moving comments from a different PR - For instance, the root cause of this one is here: |
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2018_02_01/models/_models.py
Outdated
Show resolved
Hide resolved
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2018_02_01/models/_models_py3.py
Outdated
Show resolved
Hide resolved
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2018_11_01/models/_models.py
Outdated
Show resolved
Hide resolved
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2019_08_01/models/_models.py
Outdated
Show resolved
Hide resolved
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2019_08_01/models/_models.py
Outdated
Show resolved
Hide resolved
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2019_08_01/models/_models_py3.py
Outdated
Show resolved
Hide resolved
sdk/appservice/azure-mgmt-web/azure/mgmt/web/v2019_08_01/models/_models_py3.py
Outdated
Show resolved
Hide resolved
| :param filter: An OData $filter clause. For more information on | ||
| constructing this filter, see | ||
| https://docs.microsoft.com/rest/api/batchservice/odata-filters-in-batch#list-support-images. | ||
| https://docs.microsoft.com/en-us/rest/api/batchservice/odata-filters-in-batch#list-support-images. |
There was a problem hiding this comment.
sorry, just confused why you're adding back 'en-us' in this commit, lmk if I'm missing ontext
There was a problem hiding this comment.
#12697 (comment) This code is autogenerated so it won't make a difference if i change here, it will be overridden
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
You are removing 189.842 lines! :o
Looking closely, in some cases you actually remove recordings in this PR. There should be no YAML files touched at all in this PR. There is way in git to play with sub-folder checkout to make sure of that.
|
|
||
| For more information on the relationship between AAD Applications and Service | ||
| Principals see: https://docs.microsoft.com/en-us/azure/active-directory/develop/app-objects-and-service-principals | ||
| Principals see: https://docs.microsoft.com/azure/active-directory/develop/app-objects-and-service-principals |
There was a problem hiding this comment.
This is going to need to be changed in the azure-sdk-tools repo.
|
@KarishmaGhiya lets limit the changes here to rst and md files. The yaml files are test recordings and we cannot change them without breaking the tests. The py files are mostly generated so changing them will do no good without updating the source where they come from. After chatting with @lmazuel he suggested we instead try to update these links in the azure-rest-api-specs repo which contains the swagger files which is where these come from. As part of doing that lets please reset the branch to one commit to avoid a build storm, ping me if you need help doing that. |
|
Closed this in favour of PR #13102 |
4 participants
